Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial IK seed #46

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Conversation

SammyRamone
Copy link
Contributor

This small PR adds an option to specify the initial IK seed.
It was helpful for my use case to be able to specify this, as I am using a high DoF robot and a difficult to reach workpiece.
Maybe it is helpful for others too. If you don't want to add this feature, it is also fine for me.
As long a this parameter is not defined, previous behavior of using the zero pose is used.
For the demo study, one can for example add the following to the optimization part of the config yaml (although it does not provide an advantage in this simple case).

  initial_seed:
    - name: joint_s
      position: 2.66
    - name: joint_l
      position: -1.54
    - name: joint_e
      position: -0.56
    - name: joint_u
      position: -2.20
    - name: joint_r
      position: -0.32
    - name: joint_b
      position: 1.81
    - name: joint_t
      position: 2.39

Copy link
Member

@marip8 marip8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a reasonable addition. Would you mind adding this seed_state parameter to the unit test config file as an example for others as well?

src/reach_study.cpp Outdated Show resolved Hide resolved
@marip8
Copy link
Member

marip8 commented May 16, 2023

Also, please run the .run-clang-format file to format your code additions

include/reach/reach_study.h Outdated Show resolved Hide resolved
@SammyRamone SammyRamone requested a review from marip8 May 17, 2023 07:19
@SammyRamone
Copy link
Contributor Author

Thanks for the feedback, I tried to implement the changes in the last commit.

src/reach_study.cpp Outdated Show resolved Hide resolved
src/reach_study.cpp Outdated Show resolved Hide resolved
test/reach_study.yaml Outdated Show resolved Hide resolved
@SammyRamone SammyRamone requested a review from marip8 June 1, 2023 11:51
@SammyRamone
Copy link
Contributor Author

I worked in your suggestions. Sorry for taking to so long.

Copy link
Member

@marip8 marip8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks for the updates

@marip8 marip8 merged commit 3495777 into ros-industrial:master Jun 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants