Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong log level on canopen_ros2_control cia402_data.hpp #179

Closed
lucasmluza opened this issue Jul 21, 2023 · 0 comments
Closed

Wrong log level on canopen_ros2_control cia402_data.hpp #179

lucasmluza opened this issue Jul 21, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@lucasmluza
Copy link

lucasmluza commented Jul 21, 2023

Hello. I notice that in canopen_ros2_control/include/canopen_ros2_control/cia402_data.hpp, at line 66, the log level should be INFO, and not ERROR.

node_id = config["node_id"].as<uint16_t>();
RCLCPP_ERROR(
rclcpp::get_logger(joint_name), "Node id for '%s' is '%u'", joint.name.c_str(), node_id);

    if (!config["node_id"])
    {
      RCLCPP_ERROR(rclcpp::get_logger(joint_name), "No node id for '%s'", joint.name.c_str());
      return false;
    }

    node_id = config["node_id"].as<uint16_t>();
-   RCLCPP_ERROR(
+   RCLCPP_INFO(
      rclcpp::get_logger(joint_name), "Node id for '%s' is '%u'", joint.name.c_str(), node_id);
@lucasmluza lucasmluza added the bug Something isn't working label Jul 21, 2023
jclinton830 added a commit to jclinton830/ros2_canopen that referenced this issue Oct 20, 2023
hellantos pushed a commit that referenced this issue Nov 3, 2023
@ipa-vsp ipa-vsp closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants