Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yaml parsing & Static linkage #8

Closed
wants to merge 20 commits into from

Conversation

durovsky
Copy link
Contributor

  • Yaml adopted to 14.04 API
  • Static linkage of dk16xx library to resolve third party dependency problems
  • updated .travis.yml

@@ -0,0 +1 @@
Subproject commit 31f2b420a0816e459273078445dacd805d9501e3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "new" or "preferred" way of utilizing travis is to have travis clone the industrial_ci repo, instead of including it as a submodule. This ensures that the latest version of industrial_ci is always used. The sub-module approach still works though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example of the new travis ci usage can be found here: https://github.com/ros-industrial/industrial_core/blob/indigo-devel/.travis.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't know that, I will try second approach next time

@shaun-edwards
Copy link
Member

Is there a reason you chose to include the Siemens header files in our repo? Are we certain the license allows this? If it does, I would prefer we capture all the non-ROS-I headers in their own folder.

Since you have switched to 14.04 these changes will only apply to ROS Indigo. Let's address any issues in this PR, but then open a new one to a indigo-devel branch.

@durovsky
Copy link
Contributor Author

Sorry do not merge this PR, I was just testing what needs to be done in order to get Travis build passed successfully - that is the reason for including all the headers etc. Keeping PR open seemed to be the easiest way to restart build after each iteration :) Now when build succeeded I finally understand what was missing I will try to organize all the code in proper manner. I was about to close this this evening but you were just faster.

@durovsky durovsky closed this Dec 30, 2015
gavanderhoorn pushed a commit to gavanderhoorn/siemens_experimental that referenced this pull request Jan 10, 2016
…stall

cp1616: add note about not installing test files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants