Update ur kinematics #616
Merged
Update ur kinematics #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
|
BTW: The DH parameters are extracted from https://www.universal-robots.com/articles/ur/application-installation/dh-parameters-for-calculations-of-kinematics-and-dynamics/ |
RobertWilbrandt
requested changes
Nov 8, 2022
Since the state of this package questionable at the current point, let's disable releasing it for now.
fmauch
force-pushed
the
update_ur_kinematics
branch
from
ad58bcb
to
65e27c9
Compare
RobertWilbrandt
approved these changes
Nov 8, 2022
|
Was this merged with a squash-merge? Please only use those for single-commit PRs. |
|
I would have squashed the PR anyway, so we simply skipped that step. |
|
Why? All 4 commits make sense to me to be separate commits. Thematically they don't belong together, so better to keep them as separate commits. |
|
OK, I'll keep that in mind in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #613 I collected a couple of reasons why I think that ur_kinematics is currently flawed. This PR addresses a couple of them.
kinematics_solver_attemptsas suggested in Fix MoveIt API change error for attempts #474kinematics.yamlfilesSince I still see issues with using this plugin due to its problems regarding robot calibration I added a README to inform users about this concern.
This closes #460