Add API method for getting all build_types regardless of conditions. #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more of a spike than anything. I'm not convinced this is the best way to go for this particular issue but it was the first thought that came to my head. Of possibly more concern is that this gets us past the "first hurdle" but I'm unclear why the simple version bump doesn't crash also.
cottsay
approved these changes
May 24, 2022
nuclearsandwich
force-pushed
the
336/conditional-build-type
branch
from
0b54819
to
8871546
Compare
nuclearsandwich
commented
May 25, 2022
src/catkin_pkg/package.py
Outdated
| @@ -166,6 +166,18 @@ def get_build_type(self): | |||
| return build_type_exports[0] | |||
| raise InvalidPackage('Only one <build_type> element is permitted.', self.filename) | |||
|
|
|||
| def get_build_types(self): | |||
There was a problem hiding this comment.
@cottsay should we rename this to something like get_unconditional_build_types() or somesuch to make it more obvious that this is an "advanced" method?
Should we also or alternatively prefix it with _?
Suggested change
| def get_build_types(self): | |
| def _get_unconditional_build_types(self): |
There was a problem hiding this comment.
I don't think it would hurt, but I also think that adding docs to the function would be is sufficient.
There was a problem hiding this comment.
I did decide to rename it without the _ prefix. Documentation for the method also indicates that conditions are not considered.
nuclearsandwich
added a commit
that referenced
this pull request
May 27, 2022
These patches were interleaved and #340 was not updated before being merged.
nuclearsandwich
added a commit
that referenced
this pull request
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more of a spike than anything. I'm not convinced this is the
best way to go for this particular issue but it was the first thought
that came to my head.
Of possibly more concern is that this gets us past the "first hurdle"
but I'm unclear why the simple version bump doesn't crash also.