loosening OpenCV requirements for Kinetic/Lunar #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the latest OSX support, we had to go from 3.1 to 3.2 in Kinetic. For Gentoo support, we have to go from 3.2 to 3.3 in Kinetic/Lunar. No major API/ABI changes as far as I can tell. The latest cv_bridge will force the use of OpenCV 3.3 anyway.
mikaelarguedas
approved these changes
Nov 7, 2017
There was a problem hiding this comment.
lgtm,
@tfoote as the Kinetic ROS boss are you in favor of merging this? (Knowing that to the best of our knowledge OpenCV tries to stay API/ABI compatible between minor releases)
Note: the corresponding rosdistro PRs have been merged.
tfoote
approved these changes
Nov 15, 2017
This was referenced Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the latest OSX support, we had to go from 3.1 to 3.2 in Kinetic.
For Gentoo support, we have to go from 3.2 to 3.3 in Kinetic/Lunar.
No major API/ABI changes as far as I can tell.
The latest cv_bridge will force the use of OpenCV 3.3 anyway.