Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure 'distro' dependency is absent for python < 3.8 #196

Merged
merged 4 commits into from
Apr 20, 2020
Merged

Ensure 'distro' dependency is absent for python < 3.8 #196

merged 4 commits into from
Apr 20, 2020

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Apr 20, 2020

This approach aligns with the existing approach for argparse, while still maintaining the current behavior when SKIP_PYTHON_{MODULES,SCRIPTS} is specified.

This is a generalized solution to the change made in #186

This approach aligns with the existing approach for `argparse`, while
still maintaining the current behavior when
`SKIP_PYTHON_{MODULE,SCRIPTS}` is specified.

This is a generalized solution to the change made in
e7a1549
@cottsay
Copy link
Member Author

cottsay commented Apr 20, 2020

Travis is failing because we're getting a prerelease of pyparsing 3.0.0.

@dirk-thomas
Copy link
Member

I just tried to simplify the logic a bit in 67bab6e. d36a67b is still necessary (even thought the Debian package depends on python3-distro in Python 3.8 and higher) since the same Debian package is used for multiple Ubuntu / Debian distros with different Python versions.

@dirk-thomas dirk-thomas merged commit f3c8e8e into ros-infrastructure:master Apr 20, 2020
@cottsay cottsay deleted the distro_dep branch April 20, 2020 21:45
dirk-thomas added a commit that referenced this pull request May 4, 2020
@dirk-thomas dirk-thomas added this to the 1.2.5 milestone Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants