Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions for rospkg CI. #212

Merged
merged 6 commits into from
Nov 13, 2020
Merged

Use GitHub Actions for rospkg CI. #212

merged 6 commits into from
Nov 13, 2020

Conversation

nuclearsandwich
Copy link
Contributor

With the exception of 3.4 which is not supported by the setup-python
action so we leave that one set up in Travis for the (likely brief)
remainder of python 3.4 support.

This is mostly a port of the travis handling. I did change nosetests to python -m nose

With the exception of 3.4 which is not supported by the setup-python
action so we leave that one set up in Travis for the (likely brief)
remainder of python 3.4 support.
Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, a couple of notes, but no blockers.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@nuclearsandwich nuclearsandwich merged commit 9404cf1 into master Nov 13, 2020
@nuclearsandwich nuclearsandwich deleted the github-actions branch November 13, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants