Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os_detect: support macOS Big Sur #213

Closed
wants to merge 1 commit into from

Conversation

okalachev
Copy link

@okalachev okalachev commented Dec 1, 2020

rosdep update is now failing on macOS Big Sur.

This commit makes it not to fail and detect it correctly.

@bjajoh
Copy link

bjajoh commented Dec 22, 2020

@dirk-thomas @tfoote Please merge if possible, I'm also highly interested in this fix. :)

@dirk-thomas
Copy link
Member

@bjajoh I am not the maintainer of this repository anymore. Hopefully the new maintainer will provide you with feedback soon (unfortunately I don't recall who that is).

@rtwomey
Copy link

rtwomey commented Jan 1, 2021

I believe this will cover Big Sur through the beta, but the current latest version is 11.1. As of this writing, running sw_vers -productVersion unfortunately returns 11.1. I guess that means "Big Sur" is the codename for both 11.0 and 11.1....

@smnogar
Copy link
Contributor

smnogar commented Jan 4, 2021

I believe this will cover Big Sur through the beta, but the current latest version is 11.1. As of this writing, running sw_vers -productVersion unfortunately returns 11.1. I guess that means "Big Sur" is the codename for both 11.0 and 11.1....

I just pushed a new PR that should address this issue.

@tfoote
Copy link
Member

tfoote commented Jan 23, 2021

Closing in favor of #216

@tfoote tfoote closed this Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants