Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch RedHat-likes to FdoDetect, add some RHEL clones #219

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Mar 25, 2021

Switch all remaining RedHat distributions to use FdoDetect instead of the custom /etc/redhat-release detection.

Also add support for AlmaLinux, Amazon Linux, Oracle Linux, and Rocky Linux.

Results of running python3 -m rospkg.os_detect on each of these platforms:

  • AlmaLinux 8:
    OS Name:     almalinux
    OS Version:  8.3
    OS Codename: purple manul
    
  • Amazon Linux 2:
    OS Name:     amazon
    OS Version:  2
    OS Codename: 2
    
  • CentOS 7:
    OS Name:     centos
    OS Version:  7
    OS Codename: core
    
  • CentOS 8:
    OS Name:     centos
    OS Version:  8
    OS Codename: 8
    
  • EulerOS:
    OS Name:     euleros
    OS Version:  2.0
    OS Codename: sp3
    
  • Oracle Linux 8.3:
    OS Name:     oracle
    OS Version:  8.3
    OS Codename: 8.3
    
  • RHEL 7:
    OS Name:     rhel
    OS Version:  7.6
    OS Codename: maipo
    
  • RHEL 8:
    OS Name:     rhel
    OS Version:  8.2
    OS Codename: ootpa
    
  • Rocky Linux
    OS Name:     rocky
    OS Version:  8
    OS Codename: 8
    

Switch all remaining RedHat distributions to use FdoDetect instead of
the custom /etc/redhat-release detection.

Also add support for AlmaLinux, Amazon Linux, Oracle Linux, and
Rocky Linux.
@cottsay cottsay self-assigned this Mar 25, 2021
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving forward on this makes a lot of sense. It's a lot cleaner and simpler.

RHEL 6 is over 10 years old and is into ELS so not officially supported. That's fine to drop it for us. If you're using the ELS you can choose to pin an older version for your older platform.

@cottsay cottsay merged commit c7a43b9 into master Mar 31, 2021
@cottsay cottsay deleted the cottsay/redhat-fdo branch March 31, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants