ManifestManager.list() should return a list #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In python3 this is returning a "dict_keys", that for example broke code like this: ```python3 self.allnames = sorted(list(set(rospack.list() + rosstack.list()))) ``` because the `+` operator isn't supported by `dict_keys`. See [this](ros-visualization/rqt_dep#15 (comment)) and [this](ros-visualization/rqt_dep#15 (comment)) comments. Downstream packages can also fix this directly, but it would be better if the `list()` method actually returned a python `list`.
|
@cottsay Friendly ping - any thoughts on this PR? Tools like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python3 this is returning a "dict_keys", that for example broke code like this:
because the
+operator isn't supported bydict_keys.See this and this comments.
Downstream packages can also fix this directly, but it would be better if the
list()method actually returned a pythonlist.