-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare test dependencies in [test] extra #251
Conversation
Also introduce a constraints file to handle Python 2 in CI.
5b71417
to
8c693d1
Compare
As I understand it, these constraints are for indirect dependencies which is why they aren't expressed directly in setup.py. |
Eh, I could go either way. We could probably do that and then just drop it when we drop Python 2 support. I'm 50/50 on this, so you'll have to be the deciding vote. |
Yeah that seems reasonable to me.
My overarching preference is for CI actions to "just run repository scripts" and thus the only contents stashed into CI subdirectories ought to be CI-only so let's move the constraints.txt file to the repo root. |
by the by I very much appreciate making this explicit since my default tiebreaker is "implementing maintainers choice" |
Done in 50636cf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing review suggestions and answering questions!
Also introduce a constraints file to handle Python 2 in CI.