Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare test dependencies in [test] extra #251

Merged
merged 2 commits into from
Mar 11, 2022
Merged

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Mar 7, 2022

Also introduce a constraints file to handle Python 2 in CI.

@cottsay cottsay self-assigned this Mar 7, 2022
Also introduce a constraints file to handle Python 2 in CI.
@cottsay cottsay marked this pull request as ready for review March 7, 2022 19:06
@nuclearsandwich
Copy link
Contributor

Also introduce a constraints file to handle Python 2 in CI.

As I understand it, these constraints are for indirect dependencies which is why they aren't expressed directly in setup.py.
Does it make sense to place the file at the package root so that it's more readily discoverable for others building from source (especially in python2 environments)?

@cottsay
Copy link
Member Author

cottsay commented Mar 11, 2022

Does it make sense to place the file at the package root...?

Eh, I could go either way. We could probably do that and then just drop it when we drop Python 2 support.

I'm 50/50 on this, so you'll have to be the deciding vote.

@nuclearsandwich
Copy link
Contributor

We could probably do that and then just drop it when we drop Python 2 support.

Yeah that seems reasonable to me.

I'm 50/50 on this, so you'll have to be the deciding vote.

My overarching preference is for CI actions to "just run repository scripts" and thus the only contents stashed into CI subdirectories ought to be CI-only so let's move the constraints.txt file to the repo root.

@nuclearsandwich
Copy link
Contributor

so you'll have to be the deciding vote.

by the by I very much appreciate making this explicit since my default tiebreaker is "implementing maintainers choice"

@cottsay
Copy link
Member Author

cottsay commented Mar 11, 2022

...let's move the constraints.txt file to the repo root.

Done in 50636cf.

Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing review suggestions and answering questions!

@cottsay cottsay merged commit 7de384c into master Mar 11, 2022
@cottsay cottsay deleted the cottsay/test-reqs branch March 11, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants