-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use index for querying distro information #171
Conversation
Lgtm. Leaving for @tfoote to merge |
Now that the index-v4.yaml file includes information about ROS 1 vs ROS 2 distributions. Is it possible to use the index rather than hard-coding distribution lists in the tool? |
In fact, looking more closely at the source I'm not sure that the commit message formatting even merits working that hard. And it makes it harder for orgs with forked rosdistros to use superflore. |
I've opened #172 which removes the hard coded distro lists from commit messages but couldn't quickly replace the last hard coded list. I still believe it's possible to do so and have left details on the other PR. |
Great @nuclearsandwich @allenh1 , thanks! I pushed a change on top of yours (depends on #172) adding the support to get the hardcoded information from the index instead. Could you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andre-rosa Thanks for filling in the rosdistro index logic! It looks good. Though I merged #172 before realizing that this had integrated it too but apparently this needs a rebase to merge. Otherwise it lgtm.
@tfoote << Thank you for reviewing! I rebased it on top of the dependent changes. Could you please take another look? |
Thanks, I'll rebase now! |
https://index.ros.org//doc/ros2/Releases/Release-Dashing-Diademata/