Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened as an alternative to #171.
This PR reducing the amount of rosdistro hard-coding in commit message formatting. There is only one change in the generated text (unless I've made an error) which is that commit messages for ROS 2 distributions will now say
ros-ROSDISTRO, TIMESTAMP
rather thanros2-ROSDISTRO, TIMEPSTAMP
. I believe this change to be acceptable given the simplification it enables.I would have liked to remove the last hard-coded list of active ROS and ROS 2 distros but I only gave myself 10 minutes to make this change. I'd have no problem if @allenh1 or @andre-rosa wanted to address the TODO before this is merged. I do not know when I would have time to return to it.
In case we decide to merge the incremental improvement I also added dashing to the final hard-coded list so this PR should replace #171 as-is with similar functionality.