Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitbake: Fix path to cache.yaml in various places #269

Merged
merged 1 commit into from
Mar 23, 2020
Merged

bitbake: Fix path to cache.yaml in various places #269

merged 1 commit into from
Mar 23, 2020

Conversation

shr-project
Copy link
Contributor

…le_revision_logs() call

Signed-off-by: Martin Jansa martin.jansa@lge.com

@shr-project
Copy link
Contributor Author

Fixes #264

@shr-project shr-project mentioned this pull request Feb 5, 2020
Merged
herb-kuta-lge
herb-kuta-lge requested changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@herb-kuta-lge herb-kuta-lge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest commit message:

bitbake: Fix path to cache.yaml in two places

@herb-kuta-lge herb-kuta-lge changed the title yocto_recipe.py: fix path to cache.yaml in comment and overlay.get_fi… bitbake: Fix path to cache.yaml in two places Feb 14, 2020
herb-kuta-lge
herb-kuta-lge requested changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@herb-kuta-lge herb-kuta-lge left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Old name of cache.yaml still appears on lines 147 and 213 of run.py .
  • Add Fixes #264 to commit message.
  • Change summary line to bitbake: Fix path to cache.yaml in various places.

@herb-kuta-lge herb-kuta-lge changed the title bitbake: Fix path to cache.yaml in two places bitbake: Fix path to cache.yaml in various places Feb 14, 2020
@shr-project shr-project force-pushed the jansa/yaml branch 2 times, most recently from 55d6cfc to 47d0a0c Compare March 20, 2020 18:32
herb-kuta-lge
herb-kuta-lge reviewed Mar 20, 2020
View reviewed changes
superflore/generators/bitbake/run.py Outdated Show resolved Hide resolved
superflore/generators/bitbake/run.py Outdated Show resolved Hide resolved
herb-kuta-lge
herb-kuta-lge requested changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@herb-kuta-lge herb-kuta-lge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message suggestions:

Fix path to cache.yaml in comment and overlay.get_file_revision_logs() call

Change to:

Fix path to cache.yaml in generated comment in superflore-ros-distro.inc, overlay.get_file_revision_logs() call, and commit summaries.

@shr-project
bitbake: Fix path to cache.yaml in various places.
f747d5a 
* Fix path to cache.yaml in generated comment in
  superflore-ros-distro.inc, overlay.get_file_revision_logs() call, and
  commit summaries.
* Fixes ros-infrastructure#264

Signed-off-by: Martin Jansa <martin.jansa@lge.com>
@herb-kuta-lge herb-kuta-lge merged commit 9f78fe2 into ros-infrastructure:master Mar 23, 2020
@shr-project shr-project deleted the jansa/yaml branch March 23, 2020 13:46
@herb-kuta-lge herb-kuta-lge added this to the Version 0.3.2 milestone Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herb-kuta-lge herb-kuta-lge herb-kuta-lge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.3.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shr-project @herb-kuta-lge