rename tactile touch to head touch #75
Conversation
| @@ -78,11 +78,11 @@ | |||
| { | |||
| "enabled" : true | |||
| }, | |||
| "tactile": | |||
There was a problem hiding this comment.
can we name it tactile_hand or touch_hand?
There was a problem hiding this comment.
Thank you very much for your comment.
I renamed it to touch_hand.
| { | ||
| "enabled" : true | ||
| }, | ||
| "hand": | ||
| "head": |
There was a problem hiding this comment.
can we name it tactile_head or touch_head?
There was a problem hiding this comment.
Thank you very much for your comment.
I also renamed it to touch_head.
|
Thank you very much for your reviews. |
|
great, thank you! |
|
@nlyubova, you need to release the new messages to take that into account, otherwise the buildfarm fails and you receive emails :) |
|
@vrabaud right, I've also merged the corresponding PR in naoqi_bridge_msgs but then realized that there are many pending PR there and thus did not release it. No worries, will fix it! |
|
@vrabaud @suryaambrose @Karsten1987 I've just released naoqi_bridge_msgs, sorry Karsten for releasing your package but otherwise naoqi_driver would complain ............. and I did not merge any other PR in naoqi_bridge_msgs; please decide if you prefer to merge (especially naoqi_apps related messages) or not |
|
No problem. We can also transfer ownership as I have only little control over it from remote. |
…o-head-touch rename tactile touch to head touch
Based on the discussion in ros-naoqi/naoqi_bridge_msgs#4,
I renamed tactileTouch (for head touch sensor) to headTouch.
In addtion, put it and handTouch in an alphabetical order.
It requires ros-naoqi/naoqi_bridge_msgs#29 .
One concern is that even though renaming TactileTouch to HeadTouch would be more easy to follow for me, it may have an effect on TactileTouch topic users.
If there is any problem/ comment, please let me know.