fix when no name space is found #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -89,7 +89,7 @@ static void setMasterURI( const std::string& uri, const std::string& network_int | |||
| remap["__master"] = uri; | |||
| remap["__ip"] = ::naoqi::ros_env::getROSIP(network_interface); | |||
| // init ros without a sigint-handler in order to shutdown correctly by naoqi | |||
| ros::init( remap, ::naoqi::ros_env::getPrefix(), ros::init_options::NoSigintHandler ); | |||
| ros::init( remap, ::naoqi::ros_env::getPrefix().empty()?std::string("naoqi_dirver_node"):(::naoqi::ros_env::getPrefix()) , ros::init_options::NoSigintHandler ); | |||
There was a problem hiding this comment.
@k-okada can you correct the spelling mistake first ^^ ?
k-okada
force-pushed
the
add_when_no_prefix
branch
from
9425caa
to
b7f161c
Compare
vrabaud
added a commit
that referenced
this pull request
Jan 10, 2016
fix when no name space is found
k-okada
added a commit
to k-okada/naoqi_driver
that referenced
this pull request
Jan 26, 2016
vrabaud
added a commit
that referenced
this pull request
Feb 2, 2016
PR #58 is not compatible with previous version...
kochigami
pushed a commit
to kochigami/naoqi_driver
that referenced
this pull request
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.