Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pepper_bringup] add namespace arg to naoqi_driver.launch #37

Closed

Conversation

kochigami
Copy link
Contributor

I added namespace arg instead of adding it as a group name.
This pull-request is related to ros-naoqi/naoqi_driver#81 .
If there is any problem, please let me know.

The result is like this:

roslaunch pepper_bringup pepper_full.launch 
=> 
rosnode list
/pepper_robot
/pepper_robot/camera/bottom_rectify_color
/pepper_robot/camera/camera_nodelet_manager
/pepper_robot/camera/depth_metric
/pepper_robot/camera/depth_metric_rect
/pepper_robot/camera/depth_rectify_depth
/pepper_robot/camera/depth_registered_hw_metric_rect
/pepper_robot/camera/depth_registered_metric
/pepper_robot/camera/depth_registered_rectify_depth
/pepper_robot/camera/depth_registered_sw_metric_rect
/pepper_robot/camera/front_rectify_color
/pepper_robot/camera/ir_rectify_ir
/pepper_robot/camera/points_xyzrgb_hw_registered
/pepper_robot/camera/points_xyzrgb_sw_registered
/pepper_robot/camera/register_depth_front
/pepper_robot/pose/pose_controller
/pepper_robot/pose/pose_manager
/rosout

@kochigami
Copy link
Contributor Author

I modified this in accordance with the change of ros-naoqi/naoqi_driver#81 .
Travis test fails because this requires the pull-request.

@nlyubova
Copy link
Member

+1 @suryaambrose ?

@mikaelarguedas
Copy link
Member

Note: the test is failing with this modification to the launchfile

@nlyubova
Copy link
Member

right, @mikaelarguedas what should we do with these both requests? should we finish it or leave?

@mikaelarguedas
Copy link
Member

This PR is fine, but the "namespace" argument should be added to naoqi_driver.launch that currently doesn't know expose this argument

@kochigami
Copy link
Contributor Author

same comment as ros-naoqi/naoqi_driver#81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants