Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation for rolling #515

Conversation

Ryanf55
Copy link
Contributor

@Ryanf55 Ryanf55 commented Feb 1, 2024

Purpose

  • Use the correct branch
  • Don't pull in vcs sources for geometry2
  • Handle slam_toolbox circular dependency in the background automatically
  • Add note that binaries are not available for rolling. If this changes, then a new section can be added
  • Be able to compile NAV2 on rolling following the instructions verbatim without errors

How to test

Use this dockerfile:

ARG ROS_DISTRO=rolling
FROM ros:${ROS_DISTRO}-ros-core

RUN apt-get update \
    && apt-get install -y \
        ros-dev-tools \
        wget
        
WORKDIR /root/ros2_ws 
RUN mkdir -p ~/ros2_ws/src
RUN git clone https://github.com/ros-planning/navigation2.git --branch main ./src/navigation2
RUN rosdep init

SHELL ["/bin/bash", "-c"]
RUN apt-get update \
    && rosdep update \
    && source /opt/ros/${ROS_DISTRO}/setup.bash \
    && rosdep install -y -r --ignore-src --from-paths src

RUN source /opt/ros/${ROS_DISTRO}/setup.bash \ 
    && colcon build --symlink-install

ANd run
docker build .

Note - because it's rolling, this may not be reproducible, but it works today.

* Use correct branch
* Don't pull in vcs sources for geometry2
* Handle slam_toolbox circular dependency in the background
  automatically

Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
@SteveMacenski SteveMacenski merged commit fd1ec71 into ros-navigation:master Feb 1, 2024
1 check passed
@Ryanf55 Ryanf55 deleted the fix-rolling-source-build-instructions branch February 1, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants