Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ros2_dependencies.repos #407

Closed
wants to merge 1 commit into from

Conversation

Claudio-Chies
Copy link

Fixes an which comes apprears during ````colcon build --symlink-install --packages-up-to pcl_roswhich thre mePackage 'pcl_ros' specified with --packages-up-to was not found``` (same issue as in old Issue

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Feb 1, 2024

Hello,

Thanks for the info. Do you mind first fixing this on the rolling branch? Feel free to re-use this PR, and just change the target branch. Once it goes into rolling, I can backport to iron and humble.

Also, how do the nav2 dependencies get installed? In rolling, I think we need to compile nav2 from source because it doesn't have binaries available.

ryan@B650-970:~/Dev/grid_map_ws$ rosdep install -y --ignore-src --from-paths src
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
grid_map_costmap_2d: Cannot locate rosdep definition for [nav2_costmap_2d]
grid_map_ros: Cannot locate rosdep definition for [nav2_msgs]

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Feb 1, 2024

I talked to Steve from NAV2, and for rolling, it will need to be compiled from source, and rosdep should use the -r flag because of circular dependencies in slam_toolbox.

For humble and iron, we should use binaries for nav2 and not compile dependencies from source.

The NAV2 guide on compiling rolling from source is currently incorrect, and I will submit a patch to fix it.
See ros-navigation/docs.nav2.org#515

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Feb 2, 2024

perception_pcl is available in the ROS index, and should be brought in through rosdep.
https://index.ros.org/p/perception_pcl/github-ros-perception-perception_pcl/#humble

Can you try that instead?

@Ryanf55 Ryanf55 added this to the 2.2.0 milestone Feb 3, 2024
@Ryanf55
Copy link
Collaborator

Ryanf55 commented Feb 20, 2024

Humble CI is passing without compiling any dependencies from source. Because I got no response, and need to more forward with the release, I'm closing this.

@Ryanf55 Ryanf55 closed this Feb 20, 2024
@Claudio-Chies Claudio-Chies deleted the patch-2 branch March 26, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid ros2 Affects ROS 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants