Addressing pull request feedback

ros-navigation · Jan 11, 2019 · 97b0cd2 · 97b0cd2
1 parent 817c108
commit 97b0cd2
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 60 deletions.
diff --git a/nav2_util/include/nav2_util/point.hpp b/nav2_util/include/nav2_util/point.hpp
@@ -26,15 +26,8 @@ struct Point
 {
   double x, y;
 
-  Point()
-  : x(0), y(0)
-  {
-  }
-
   Point(const double x, const double y)
-  : x(x), y(y)
-  {
-  }
+  : x(x), y(y) { }
 
   bool operator==(const Point & obj) const
   {

diff --git a/nav2_world_model/include/nav2_world_model/clear_area_service_client.hpp b/nav2_world_model/include/nav2_world_model/clear_area_service_client.hpp
@@ -28,6 +28,10 @@ using ClearAreaServiceRequest =
 using ClearAreaServiceResponse =
   ServiceClient<ProcessRegion>::ResponseType;
 
+/*
+ * A class that creates a ROS service for clearing the occupancy information of a region
+ */
+
 class ClearAreaServiceClient : public ServiceClient<ProcessRegion>
 {
 public:

diff --git a/nav2_world_model/include/nav2_world_model/costmap_service_client.hpp b/nav2_world_model/include/nav2_world_model/costmap_service_client.hpp
@@ -30,6 +30,10 @@ using CostmapServiceRequest =
 using CostmapServiceResponse =
   ServiceClient<GetCostmap>::ResponseType;
 
+/*
+ * A class that creates a ROS service for obtaining a costmap
+ */
+
 class CostmapServiceClient : public ServiceClient<GetCostmap>
 {
 public:

diff --git a/nav2_world_model/include/nav2_world_model/free_space_service_client.hpp b/nav2_world_model/include/nav2_world_model/free_space_service_client.hpp
@@ -30,6 +30,10 @@ using FreeSpaceServiceRequest =
 using FreeSpaceServiceResponse =
   ServiceClient<ProcessRegion>::ResponseType;
 
+/*
+ * A class that creates a ROS service for checking the occupancy of a region
+ */
+
 class FreeSpaceServiceClient : public ServiceClient<ProcessRegion>
 {
 public:

diff --git a/nav2_world_model/include/nav2_world_model/rectangular_region.hpp b/nav2_world_model/include/nav2_world_model/rectangular_region.hpp