Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website page for configuration guide and setup instructions #1589

Closed
9 tasks done
SteveMacenski opened this issue Mar 9, 2020 · 11 comments
Closed
9 tasks done

Website page for configuration guide and setup instructions #1589

SteveMacenski opened this issue Mar 9, 2020 · 11 comments

Comments

@SteveMacenski
Copy link
Member

SteveMacenski commented Mar 9, 2020

Configuration guide

  • all parameters listed and their descriptions and defaults
  • Namespacing for server maps of plugins

Setup Guide

  • setup TF / REP103/105
  • setup kinematics / UDRF (+ gazebo plugins for sim)
  • setup odom sources + RL
  • setup sensor sources (+costmap gradient global at minimum to be correct + param list description links)
  • setup footprint and reference CollisionChecker detects a collision when robot footprint hits inscribed radius distance. #1603 under way
  • NEW to ROS2: Algorithm selection based on environment / robot type under way
  • NEW to ROS2: lifecycle sensors / other nodes -> up before navigation stack with lifecycle manager -> safety! (TF we handle for you) -> autonomy after navigation

@crdelsey crdelsey mentioned this issue Mar 9, 2020
47 tasks
@SteveMacenski SteveMacenski added this to Triage in V1.0.0 via automation Mar 25, 2020
@SteveMacenski SteveMacenski moved this from Triage to Documentation in V1.0.0 Mar 25, 2020
@Marwan99
Copy link
Contributor

Will start working on listing the params.

@SteveMacenski
Copy link
Member Author

@fmrico do you think its worth having a page for the marathon2 experiment on the website? If so, any ideas on what the structure / goal we're trying to leave readers with on that? I could throw something together quickly while I'm making the IROS presentation but not sure what the style of something like that should be.

@jackpien
Copy link
Contributor

@SteveMacenski - I'm carving out some cycles to address the "setup TF / REP103/105" item above.

Here's my plan:

  1. I will add a page in the navigation.ros.org repo -> Tutorials called "Setting up your robot using tf2"
  2. While recycling most of ROS1 Nav1's Setting up your robot using tf, I'm going to "port" the TF tutorial to TF2 for ROS2.
  3. Add code and instructions to show and tell a demonstration using turtlesim.

Questions:

  1. Does the plan above sound about right?
  2. Despite this "issue" being in the navigation2 repo, there's really nothing to do in this repo right (since the doxygen html from the doc folder doesn't look like it generates anything meaningful)? All the pull requests should happen in the navigation.ros.org repo right?

@SteveMacenski
Copy link
Member Author

SteveMacenski commented Sep 14, 2020

@jackpien you're a little late to the game, a team within Samsung Research has already drafted this work we're doing iterations on before submitting the PR publicly. They're covering TF, REP, and URDF items in these 2 pages.

If you'd like to apply that same interest to another one of the pages, we can carve that out for you. Right now they're only working on the transforms / URDF pages. Other ones:

  • URDF for simulation (adding plugins for sensors / drive)
  • R_L setup / odom inputs
  • Sensor feed setup / adding sensors to your robot / costmap
  • Lifecycle manager setup
  • Behavior tree setup

Correct, its all in the navigation.ros.org site

@jackpien
Copy link
Contributor

Thanks for update @SteveMacenski

* R_L setup / odom inputs

Is that basically "porting" the Nav1 Publishing Odometry Information over ROS page? What else do you envision "R_L setup" to entail?

@SteveMacenski
Copy link
Member Author

Not really that tutorial because that just goes through the message type, which isn't really important. It really should go over the odometry inputs we accept (anything that makes an odometry message; VIO, VO, wheel, IMU, mocap, etc), how to set up to fuse in R_L and the expected frames.

It might not hurt to introduce the message, but I don't see a point in the tutorial as it exists now.

@jackpien
Copy link
Contributor

It really should go over the odometry inputs we accept (anything that makes an odometry message; VIO, VO, wheel, IMU, mocap, etc), how to set up to fuse in R_L and the expected frames.

Hi @SteveMacenski - how do I get myself up to speed on the above?

  • Looking at the Nav1 Robot Setup diagram are you suggesting we need a step to describe the left-side "odometry source" box that Nav1 amcl and the controllers use?

  • A brief web search seems to suggest that ROS1 sensor fusion is done in the robot_localization which sits outside of the Nav1 stack. Is this still the case for Nav2?

  • If Nav2 does do sensor fusion from various odom sources (VIO, wheel, IMU, etc), can you point me to the code / node in Nav2 that does this?

Thanks!

@SteveMacenski
Copy link
Member Author

SteveMacenski commented Sep 14, 2020

Is this still the case for Nav2?

Yes, R_L is not in the stack. It's its own repo.

can you point me to the code / node in Nav2 that does this?

That is R_L. That's the point of R_L, it fuses in the different odometry sources using a EKF or UKF (also GPS).

@fmrico
Copy link
Contributor

fmrico commented Sep 15, 2020

Hi @SteveMacenski

@fmrico do you think its worth having a page for the marathon2 experiment on the website? If so, any ideas on what the structure / goal we're trying to leave readers with on that? I could throw something together quickly while I'm making the IROS presentation but not sure what the style of something like that should be.

We have the info in this repo: https://github.com/IntelligentRoboticsLabs/marathon_ros2
We can link this repo, or copy these instructions. Any option is ok for me.

@SteveMacenski
Copy link
Member Author

Thanks to @jd-deleon for taking leadership on this!

@SteveMacenski
Copy link
Member Author

https://navigation.ros.org/setup_guides/index.html

Done! Thanks to @jd-deleon and team! Thanks for taking the lead on this, it will continue to be helpful for users for years to come!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants