Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop planner if the goal is cancelled #4148

Merged

Handle timeout and cancel check on the same branch and default to 500…

868dd64
Select commit
Failed to load commit list.
Merged

Stop planner if the goal is cancelled #4148

Handle timeout and cancel check on the same branch and default to 500…
868dd64
Select commit
Failed to load commit list.
Codecov / codecov/project succeeded Feb 28, 2024 in 1s

90.09% (+0.23%) compared to 865fd32

View this Pull Request on Codecov

90.09% (+0.23%) compared to 865fd32

Details

Codecov Report

Attention: Patch coverage is 83.78378% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 90.09%. Comparing base (865fd32) to head (868dd64).
Report is 1 commits behind head on main.

❗ Current head 868dd64 differs from pull request most recent head a13ab59. Consider uploading reports for the commit a13ab59 to get more accurate results

Files Patch % Lines
nav2_planner/src/planner_server.cpp 73.33% 4 Missing ⚠️
nav2_navfn_planner/src/navfn.cpp 80.00% 2 Missing ⚠️
nav2_smac_planner/src/smac_planner_lattice.cpp 83.33% 2 Missing ⚠️
nav2_theta_star_planner/src/theta_star.cpp 60.00% 2 Missing ⚠️
nav2_core/include/nav2_core/planner_exceptions.hpp 0.00% 1 Missing ⚠️
nav2_smac_planner/src/a_star.cpp 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4148      +/-   ##
==========================================
+ Coverage   89.85%   90.09%   +0.23%     
==========================================
  Files         432      432              
  Lines       19406    19455      +49     
==========================================
+ Hits        17438    17528      +90     
+ Misses       1968     1927      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.