Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Melodic Release Request #29

Closed
moriarty opened this issue Feb 5, 2019 · 5 comments
Closed

Melodic Release Request #29

moriarty opened this issue Feb 5, 2019 · 5 comments

Comments

@moriarty
Copy link

moriarty commented Feb 5, 2019

@chadrockey or @mikeferguson could we merge #25 & #26 and then release this into Melodic?

I forgot about this dependency and had it installed in my melodic workspace and would like to release the fetch packages ZebraDevs/fetch_ros#63 into melodic and this is used.

https://github.com/fetchrobotics/fetch_robots/blob/melodic-devel/fetch_bringup/launch/fetch.launch#L20-L22

@mikeferguson
Copy link
Member

You want to take over maintenance? I I've been recommending people move over to robot_localization for quite some time now (it's way better documented), and so I don't have any interest in continuing to maintain it (we didn't add a Fetch maintainer because it was assumed Fetch would be migrating to robot_localization or their internal thing).

@chadrockey
Copy link
Member

Done for Fetch.

@moriarty
Copy link
Author

@mikeferguson & @chadrockey thanks.

I'll try to switch to robot_localization for the open source code... otherwise I could take over maintenance.

We've moved over to our internal thing for our commercial robots, which is why this was a last minute forgotten dependency which I had installed on to the Fetch back when I was testing the opensource melodic nav stack on the robot.

@knorth55
Copy link

What is the status of issue?
Is fetch planning to use robot_localization?

@knorth55
Copy link

I made a PR to swtich from graft to robot_localization ZebraDevs/fetch_robots#56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants