Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 Using the filesystem helper in rcpputils #133

Merged
merged 3 commits into from
Oct 22, 2019

Conversation

klintan
Copy link
Contributor

@klintan klintan commented Aug 3, 2019

This is using changes made in rcpputils reflected in this PR ros2/rcpputils#18

@mjcarroll
Copy link
Contributor

It appears that this relies on some functionality that was not imlemented in rcpputils. Can you update this to pass the Dpr job?

@mjcarroll
Copy link
Contributor

@klintan, I saw you got the necessary functionality into rcpputils, so I just rebased this.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dashing is expected to fail here as it doesn't have the new rcpputils APIs.

Thanks for the contribution!

@mjcarroll mjcarroll merged commit 00bed63 into ros-perception:ros2 Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants