Add support for missing ROI and binning fields #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbiggs
reviewed
Sep 19, 2022
camera_calibration_parsers/test/make_calibs.hpp.unc-backup.md5~
Outdated
Show resolved
Hide resolved
camera_calibration_parsers/test/test_parse_yml.cpp.unc-backup.md5~
Outdated
Show resolved
Hide resolved
|
@gbiggs Sorry I used uncrustify with ROS2 config and didn't know that it generates these backup files. Now I use it with |
gbiggs
approved these changes
Sep 20, 2022
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalently to #175 for ROS1, this pull request adds support for binning and roi fields contained in the CameraInfo.msg to the
camera_calibration_parserspackage for ROS2. So that it is able to write these fields to YAML and to read them from YAML.To properly use the ROI information I also made this pull request ros2/rviz#864 to Rviz.