Fixed stereo calibration problem with chessboard with the same number of rows and cols #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cv3. 2- Fixed stereo calibration problem with chessboard with the same number of rows and cols by rotating the corners to same direction.
|
This package has to work under OpenCV 2.4.8 (Indigo with Trusy). Your change cannot be taken. Can you please make a different pull request with that fix using http://wiki.ros.org/opencv3#Python . Thx |
|
Actually works, thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #140, the stereo calibration fails when the detection of the corners has a different order for left and right cameras. This was solved on Jan 2 for chessboard with ncols=nrows as can be seen in the issue, but the problem continued for the case ncols=nrows, where detection apart from inverted can be rotated 90 or -90 degrees.
1- Changed flags CV_LOAD_IMAGE_COLOR by IMREAD_COLOR to adapt to Opencv3.
2- Fixed stereo calibration problem with chessboard with the same number of rows and cols by rotating the corners to same direction.