Removing code from nodes #298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build failures appears unrelated to this pr |
|
agreed. Can you please use "git mv" so that we can keep the history of those classes ? Thx. |
|
Tried using git mv but same result. Looked into and apparently git history is based on filename. Using git mv tells the history to look at a new filename, however adding back the original filename, which is necessary in this case in order to preserve the functionality without requiring users to suddenly memorize a new executable. I'm looking into solutions now, but i'm currently not sure how to get the history attached to src/ files as requested. |
|
This pr has been replaced by #301 and will be closed shortly. |
|
Thx for trying. Changes were too big for git. I replicated your method with different commits. Thx ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently several classes exist in the camera_calibration/nodes directory. This prevents anyone from importing these classes for use in other projects. Moving the classes to their own file in the camera_calibration/src directory would allow importing of these classes without impacting functionality of the package. Besides doing this I noticed a few imports that did not appear to be used, so I removed these.
I have tested successfully the cameracalibrator.py and camerachecker.py and using a monocular camera but do not have a stereo set up to test with.