camera_calibration: Make sure 'calibrate' button works even if not receiving images anymore #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mouse events were only being checked and the buttons enabled/disabled when the display got redrawn on received images. This allows the calibration to be saved even when there are no more images in the queue, e.g. when a bag playback has finished.
valgur
force-pushed
the
enable-calibration-with-empty-queue
branch
from
d8e6be7
to
174cf5a
Compare
|
Sounds good, I'm going to need to test this to verify. I'm curious though, what's the button you're trying to mess with after its done? |
The "calibrate" and "save" ones. The "save" button only becomes enabled after calibration is complete, but does not currently do so if the image queue is empty. |
SteveMacenski
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mouse events are currently only being checked and the buttons being enabled/disabled when the display gets redrawn on received images.
This change allows the calibration to be saved even when there are no more images in the queue, e.g. when a bag playback has finished.