[Dashing] Add rclcpp and rclcpp_components dependencies to package.xml. #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that these are listed in CMakeLists.txt but not in package.xml and this is causing a build failure for the binary releases on build.ros2.org: http://build.ros2.org/view/Dbin_ubhf_uBhf/job/Dbin_uB64__depth_image_proc__ubuntu_bionic_amd64__binary/ Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
JWhitleyWork
approved these changes
Jul 29, 2020
No worries. Dependency issues on release are just one of those things and it's always nice when a naive PR is the right answer. |
JWhitleyWork
pushed a commit
that referenced
this pull request
Jul 29, 2020
I noticed that these are listed in CMakeLists.txt but not in package.xml and this is causing a build failure for the binary releases on build.ros2.org: http://build.ros2.org/view/Dbin_ubhf_uBhf/job/Dbin_uB64__depth_image_proc__ubuntu_bionic_amd64__binary/ Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
JWhitleyWork
pushed a commit
that referenced
this pull request
Jul 29, 2020
…570) I noticed that these are listed in CMakeLists.txt but not in package.xml and this is causing a build failure for the binary releases on build.ros2.org: http://build.ros2.org/view/Dbin_ubhf_uBhf/job/Dbin_uB64__depth_image_proc__ubuntu_bionic_amd64__binary/ Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com> Co-authored-by: Steven! Ragnarök <nuclearsandwich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that these are listed in CMakeLists.txt but not in package.xml
and this is causing a build failure for the binary releases on
build.ros2.org:
http://build.ros2.org/view/Dbin_ubhf_uBhf/job/Dbin_uB64__depth_image_proc__ubuntu_bionic_amd64__binary/