Add rclcpp and rclcpp_components dependencies to package.xml. (#569) #570
Conversation
I noticed that these are listed in CMakeLists.txt but not in package.xml and this is causing a build failure for the binary releases on build.ros2.org: http://build.ros2.org/view/Dbin_ubhf_uBhf/job/Dbin_uB64__depth_image_proc__ubuntu_bionic_amd64__binary/ Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
|
@nuclearsandwich Can I get a quick review? |
|
The build farm "failures" are due to warnings about deprecated CMake commands. However, I'll be updating all CMake files in this repo to use |
|
Thanks! |
Sorry, I should have checked whether this was an issue on mainline distros. For my future edification am I correct that targeting the mainline and then backporting is preferred to targeting a stable distribution and forward-porting? |
|
@nuclearsandwich Yeah, generally. No big deal, though. I'm working on a big overhal of the CMakeLists.txt and package.xml files in this distro. When I'm done, would you mind reviewing it? Maintainership is getting a bit thin on this repo (no future responsibility implied with the review of this PR). |
With the disclaimer that I'm rather overwhelmed by notifications, I will do my best to do so once tagged. |
|
Totally understand. Thanks! |
Forward-port of #569 to Foxy.