Fix out-of-range exception #166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
requested changes
May 16, 2024
| std::string param_base_name = base_topic.substr(ns_len); | ||
| std::replace(param_base_name.begin(), param_base_name.end(), '/', '.'); | ||
| if (base_topic.length() >= ns_len) { | ||
| std::string param_base_name = base_topic.substr(ns_len); |
There was a problem hiding this comment.
Did you already try this patch ? There is a compilation error
14:50:25 /tmp/ws/src/image_transport_plugins/zstd_image_transport/src/zstd_publisher.cpp: In member function ‘virtual void zstd_image_transport::ZstdPublisher::advertiseImpl(rclcpp::Node*, const string&, rmw_qos_profile_t, rclcpp::PublisherOptions)’:
14:50:25 /tmp/ws/src/image_transport_plugins/zstd_image_transport/src/zstd_publisher.cpp:93:22: error: ‘param_base_name’ was not declared in this scope
14:50:25 93 | declareParameter(param_base_name, pd);param_base_name is defined inside the if scope but this variable is used in the outer scope
There was a problem hiding this comment.
I haven't tried it, sorry for that. I found this issue resulting in exception in my code, and I adopted a workaround, and then I forgot to compile and test this patch. I'll fix it soon.
|
friendly ping @chenx-dust |
Sorry. I'm quite busy recently. If possible, please solve it for me, thank you. 🙏 I'll close this PR until I'm available to resolve it. Sorry for any inconvenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using relative topic name to subscribe, and the name is shorter than namespace, it will lead to out-of-range exception.
This PR is to fix it.
Backport to older version needed!!!