Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compressed subscribe impl #78

Closed
wants to merge 2 commits into from
Closed

Fix compressed subscribe impl #78

wants to merge 2 commits into from

Conversation

PhilippPolterauer
Copy link

fixed an issue with not implemented subscripeImpl with 5 arguments (options argument)

@pmusau17
Copy link

pmusau17 commented Jul 7, 2021

Hi @PhilippPolterauer! Thanks for the contribution. Unfortunately I run into this error on galactic, foxy, and rolling.

/catkin_ws/src/image_transport_plugins/compressed_image_transport/include/compressed_image_transport/compressed_subscriber.h:65:8: error: ‘void compressed_image_transport::CompressedSubscriber::subscribeImpl(rclcpp::Node*, const string&, const Callback&, rmw_qos_profile_t, rclcpp::SubscriptionOptions)’ marked ‘override’, but does not override
   65 |   void subscribeImpl(
      |        ^~~~~~~~~~~~~
In file included from /catkin_ws/src/image_transport_plugins/compressed_image_transport/src/compressed_subscriber.cpp:35:
/catkin_ws/src/image_transport_plugins/compressed_image_transport/include/compressed_image_transport/compressed_subscriber.h:65:8: error: ‘void compressed_image_transport::CompressedSubscriber::subscribeImpl(rclcpp::Node*, const string&, const Callback&, rmw_qos_profile_t, rclcpp::SubscriptionOptions)’ marked ‘override’, but does not override
   65 |   void subscribeImpl(
      |        ^~~~~~~~~~~~~
/catkin_ws/src/image_transport_plugins/compressed_image_transport/src/compressed_subscriber.cpp: In member function ‘void compressed_image_transport::CompressedSubscriber::subscribeImpl(rclcpp::Node*, const string&, const Callback&, rmw_qos_profile_t, rclcpp::SubscriptionOptions)’:
/catkin_ws/src/image_transport_plugins/compressed_image_transport/src/compressed_subscriber.cpp:102:11: error: ‘subscribeImplWithOptions’ is not a member of ‘Base’ {aka ‘image_transport::SimpleSubscriberPlugin<sensor_msgs::msg::CompressedImage_<std::allocator<void> > >’}
  102 |     Base::subscribeImplWithOptions(node, base_topic, callback, custom_qos, options);

Could you kindly take another look at the build?

@PhilippPolterauer
Copy link
Author

I'm going to look at it, but it seems i compiled against a wrong version of image_common.
which is only available for galactic. maybe you could set up a galactic branch, where this code could fit.

br

@PhilippPolterauer PhilippPolterauer closed this by deleting the head repository Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants