[Windows][melodic] Fix Windows build break #18
Conversation
|
@lucbettaieb Hope I am pinging the correct maintainer. Can you help review this change? Thanks! |
|
@seanyen Seems fine to me, however I'd like to check to make sure this still compiles on melodic on Linux and have @mikeferguson give it a thumbs up. |
|
Seems to build fine on 18.04/melodic locally. We should really have CI and tests for this stuff... lol |
|
@seanyen If this doesn't get merged in a few more days, please ping me again. |
|
@lucbettaieb -- I concur on CI -- I'll set that up tomorrow. Assuming it passes I will merge after that. @seanyen -- what is the story with running on windows? Do folks just build everything from source, or is there some form of release? Do we need to bump the release number for you as well? |
|
@mikeferguson We are working closely with OSRF to enable ROS Melodic ecosystem to Windows users. And in additions to the core part, enabling popular community packages (Currently we focues on navigation and manipulation) is also part of this effort. Currently we are building everything from source (from upstream branch), so it is ok not to bump the version. Thanks! |
|
@lucbettaieb Ping! Just as a reminder in case this is sinking in your inbox. |
|
I'm good with merging this if you are. |
|
Apologies -- forgot to circle back on this one. Pull requests should be turned on once this gets merged: ros/rosdistro#20787 -- we should be able to get this in tomorrow. |
|
Boom - CI passes. Thanks for the contribution |
|
👏 |
This is to fix the Windows build break (based on the installation from https://aka.ms/ros).