Move the C++ classes and definitions of inline functions from the Mapper.cpp file to Mapper.h file #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…per.cpp file to the Mapper.h file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, code maintainer of open_karto repo
Generally speaking, the definition of inline functions is best placed in the .h file. If the definition of the inline function is written in the .cpp file, then this function can only be used in this .cpp file.
I tried to call some inline functions in my project, such as the function GetLastScan, but it failed to compile. That’s why I noticed this problem.
Therefore, I carefully checked all the files in this repo. And I moved all the definitions of inline functions from the Mapper.cpp file to the Mapper.h file.
Furthermore, I also move the implementations of three classes (BreadthFirstTraversal, NearScanVisitor and ScanManager) from the Mapper.cpp file to the Mapper.h file.
Best
Jian Wen
wenjian@mail.nankai.edu.cn