Fix -Wdelete-non-virtual-dtor and -Wreorder warnings #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When importing karto.h into another project, I was getting the following warnings.
```
/home/turtlebot/cobalt/forked_ws/src/open_karto/include/open_karto/Karto.h: In constructor ‘karto::LocalizedRangeScanWithPoints::LocalizedRangeScanWithPoints(const karto::Name&, const RangeReadingsVector&, const PointVectorDouble&)’:
/home/turtlebot/cobalt/forked_ws/src/open_karto/include/open_karto/Karto.h:5589:29: warning: ‘karto::LocalizedRangeScanWithPoints::m_Points’ will be initialized after [-Wreorder]
const PointVectorDouble m_Points;
^~~~~~~~
/home/turtlebot/cobalt/forked_ws/src/open_karto/include/open_karto/Karto.h:5514:52: warning: base ‘karto::LocalizedRangeScan’ [-Wreorder]
LocalizedRangeScan(rSensorName, rReadings)
^
/home/turtlebot/cobalt/forked_ws/src/open_karto/include/open_karto/Karto.h:5511:5: warning: when initialized here [-Wreorder]
LocalizedRangeScanWithPoints(const Name& rSensorName, const RangeReadingsVector& rReadings,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/turtlebot/cobalt/forked_ws/src/open_karto/include/open_karto/Karto.h: In destructor ‘virtual karto::OccupancyGrid::~OccupancyGrid()’:
/home/turtlebot/cobalt/forked_ws/src/open_karto/include/open_karto/Karto.h:5657:14: warning: deleting object of polymorphic class type ‘karto::CellUpdater’ which has non-virtual destructor might cause undefined behavior [-Wdelete-non-virtual-dtor]
delete m_pCellUpdater;
^~~~~~~~~~~~~~
```
This commit fixes these warnings by adding a default destructor and reordering the initialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing karto.h into another project, I was getting the following warnings.
This commit fixes these warnings by adding a default destructor and reordering the initialization.