Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add launch files #20

Merged
merged 4 commits into from
Aug 30, 2016
Merged

add launch files #20

merged 4 commits into from
Aug 30, 2016

Conversation

k-okada
Copy link
Contributor

@k-okada k-okada commented Aug 23, 2016

this will provide re-usable launch file for opencv_apps users

@k-okada k-okada force-pushed the add-launch branch 2 times, most recently from f89aa37 to 9a16e40 Compare August 25, 2016 08:48
@wkentaro
Copy link
Member

Is providing launch file for each node really useful for users?
I think the ROS beginners can't use <include> tag in roslaunch and professionals don't use <include> because it is less customizable (can't use nodelet with an nodelet manager).
IMO providing sample launch files is enough, because user can copy the lines from it.

@k-okada
Copy link
Contributor Author

k-okada commented Aug 25, 2016

yes, I'm aware of nodelt case, and try to rewrite all launch file with
nodelt and 'use_standalone' arg option to run manager for each launch file.

from ros-perception/vision_opencv#121,

  • rosrun opencv_apps camshift did not work,
  • hard to understand test file, for example, we have to remove image_proc
    but that's difficult to understand
  • no information of parameters, need to see wiki

with launch file

  • roslaunch --rosargs camshift.launch provides information of params
  • you can copy camshift.launch to your directory and modify it

◉ Kei Okada

On Thu, Aug 25, 2016 at 6:11 PM, Kentaro Wada notifications@github.com
wrote:

Is providing launch file for each node really useful for users?
I think the ROS beginners can't use tag in roslaunch and
professionals don't use because it is less customizable (can't
use nodelet with an nodelet manager).
IMO providing sample launch files is enough, because user can copy the
lines from it.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#20 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAeG3H6-M0IyoRvDrLB34M9d3uUJqWtNks5qjVw1gaJpZM4JquBG
.

@k-okada k-okada merged commit 670a4ea into indigo Aug 30, 2016
@k-okada k-okada deleted the add-launch branch August 30, 2016 23:50
@k-okada k-okada mentioned this pull request Aug 30, 2016
@130s
Copy link
Member

130s commented Sep 8, 2016

+1 for installing launch directory.
Also +1 for the idea of making a node definition "portable/dependable" by making them a launch file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants