Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed param name #36

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Fixed param name #36

merged 1 commit into from
Oct 5, 2023

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Oct 3, 2023

This should fix the parameters naming

for example draco expose encode_speed and decode_speed. But if you have several topic publishing data, you might have collisions. This should "namespace" the parameter:

  • <topic_name>.encode_speed
  • <topic_name>.decode_speed

for example:

  • pct.point_cloud.draco.encode_speed
  • pct.point_cloud.draco.decode_speed

@ahcorde
Fixed param name
88a5aa5 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Oct 3, 2023
@ahcorde ahcorde mentioned this pull request Oct 3, 2023
Merged
john-maidbot
john-maidbot approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@john-maidbot john-maidbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! Lgtm 👍

@ahcorde ahcorde merged commit 851434a into rolling Oct 5, 2023
4 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/fix_param branch October 5, 2023 08:07
@ahcorde
Copy link
Collaborator Author

ahcorde commented Oct 5, 2023

https://github.com/Mergifyio backport humble iron

@mergify
Copy link

mergify bot commented Oct 5, 2023 •
edited
Loading

backport humble iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 5, 2023
@ahcorde @mergify
Fixed param name (#36)
4a3f5f1 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 851434a)
@mergify mergify bot mentioned this pull request Oct 5, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 5, 2023
@ahcorde @mergify
Fixed param name (#36)
3f85ea2 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 851434a)
@mergify mergify bot mentioned this pull request Oct 5, 2023
Merged
ahcorde added a commit that referenced this pull request Oct 5, 2023
@mergify @ahcorde
Fixed param name (#36) (#38)
ede2db5 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 851434a)

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Oct 5, 2023
@mergify @ahcorde
Fixed param name (#36) (#37)
b1fa092 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 851434a)

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-maidbot john-maidbot john-maidbot approved these changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahcorde @john-maidbot