Fixed MacOS M1 build #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
|
Thanks - I only had to change 2 occurrences and you changed 4. I'll test it in a few hours. |
clalancette
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
This looks to be a subset of #55. This looks good to me with green CI.
|
Merged
|
Yes it builds on MacOS M1 also. Thanks! |
ahcorde
added a commit
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Feb 20, 2024
ahcorde
added a commit
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with this issue #56
FYI @pfavr2