Rename the republish_node to pc_republish_node. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The major reason for this is that image_transport already has a republish_node, and when we are building for distribution we can't have two files named /opt/ros/rolling/lib/librepublish_node.so Rename this one to libpc_republish_node, which should remove the conflict. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
CI:
|
ahcorde
approved these changes
Mar 29, 2024
ahcorde
pushed a commit
that referenced
this pull request
Apr 1, 2024
The major reason for this is that image_transport already has a republish_node, and when we are building for distribution we can't have two files named /opt/ros/rolling/lib/librepublish_node.so Rename this one to libpc_republish_node, which should remove the conflict. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
ahcorde
pushed a commit
that referenced
this pull request
Apr 1, 2024
The major reason for this is that image_transport already has a republish_node, and when we are building for distribution we can't have two files named /opt/ros/rolling/lib/librepublish_node.so Rename this one to libpc_republish_node, which should remove the conflict. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Apr 2, 2024
The major reason for this is that image_transport already has a republish_node, and when we are building for distribution we can't have two files named /opt/ros/rolling/lib/librepublish_node.so Rename this one to libpc_republish_node, which should remove the conflict. Signed-off-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Apr 2, 2024
The major reason for this is that image_transport already has a republish_node, and when we are building for distribution we can't have two files named /opt/ros/rolling/lib/librepublish_node.so Rename this one to libpc_republish_node, which should remove the conflict. Signed-off-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major reason for this is that image_transport already has a republish_node, and when we are building for distribution we can't have two files named /opt/ros/rolling/lib/librepublish_node.so
Rename this one to libpc_republish_node, which should remove the conflict.