Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rolling] Get user specified parameters at startup #80

Merged
merged 4 commits into from
May 13, 2024
Merged

[rolling] Get user specified parameters at startup #80

merged 4 commits into from
May 13, 2024

Conversation

john-maidbot
Copy link
Collaborator

@john-maidbot john-maidbot commented May 13, 2024 •
edited

rolling version of #79

@john-maidbot john-maidbot mentioned this pull request May 13, 2024
Closed
@john-maidbot john-maidbot marked this pull request as ready for review May 13, 2024 14:38
@john-maidbot
Copy link
Collaborator Author

strange CI errors 🤔

 rosdep install --from-paths ./ -i -y -r --rosdistro $ROS_DISTRO $ROSDEP_ARGS
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
point_cloud_transport: No definition of [sensor_msgs] for OS version [jammy]
point_cloud_transport_py: No definition of [sensor_msgs] for OS version [jammy]

@john-maidbot john-maidbot requested a review from ahcorde May 13, 2024 14:42
@john-maidbot john-maidbot self-assigned this May 13, 2024
ahcorde
ahcorde approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 90c603a into rolling May 13, 2024
4 checks passed
@ahcorde ahcorde deleted the john-maidbot/rolling/get-parameters-at-startup branch May 13, 2024 17:19
@ahcorde
Copy link
Collaborator

ahcorde commented May 13, 2024

https://github.com/Mergifyio backport jazzy humble iron

@mergify Mergify
Copy link

mergify bot commented May 13, 2024 •
edited

backport jazzy humble iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 13, 2024
@john-maidbot @mergify
[rolling] Get user specified parameters at startup (#80)
c5c72fe 
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 90c603a)
@mergify mergify bot mentioned this pull request May 13, 2024
Merged
mergify bot pushed a commit that referenced this pull request May 13, 2024
@john-maidbot @mergify
[rolling] Get user specified parameters at startup (#80)
b41638d 
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 90c603a)
mergify bot pushed a commit that referenced this pull request May 13, 2024
@john-maidbot @mergify
[rolling] Get user specified parameters at startup (#80)
6806bfb 
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 90c603a)
This was referenced May 13, 2024
Merged
Merged
ahcorde pushed a commit that referenced this pull request May 13, 2024
@mergify @john-maidbot
[rolling] Get user specified parameters at startup (#80) (#83)
4f13442 
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 90c603a)

Co-authored-by: john-maidbot <78750993+john-maidbot@users.noreply.github.com>
ahcorde pushed a commit that referenced this pull request May 13, 2024
@mergify @john-maidbot
[rolling] Get user specified parameters at startup (#80) (#84)
40c4f94 
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 90c603a)

Co-authored-by: john-maidbot <78750993+john-maidbot@users.noreply.github.com>
ahcorde added a commit that referenced this pull request May 24, 2024
@mergify @john-maidbot @ahcorde
[rolling] Get user specified parameters at startup (#80) (#82)
a19e2a9 
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 90c603a)

Co-authored-by: john-maidbot <78750993+john-maidbot@users.noreply.github.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

@john-maidbot john-maidbot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@john-maidbot @ahcorde