Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed parameter names #28

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Fixed parameter names #28

merged 3 commits into from
Oct 5, 2023

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Oct 3, 2023

@ahcorde
Fixed draco param name
5adc9d3 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Oct 3, 2023
@ahcorde
Fixed parameters
0e50932 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde changed the title Fixed draco param name Fixed parameter names Oct 3, 2023
john-maidbot
john-maidbot approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@john-maidbot john-maidbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

zstd_point_cloud_transport/include/zstd_point_cloud_transport/zstd_publisher.hpp
@@ -61,6 +65,7 @@ class ZstdPublisher

private:
int encode_level_{7};
ZSTD_CCtx * zstd_context_{nullptr};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a comment about what this is?

@ahcorde
Added comment
f844e9d 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde merged commit 45c42b0 into rolling Oct 5, 2023
4 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/draco_fix_params branch October 5, 2023 08:25
@ahcorde
Copy link
Collaborator Author

ahcorde commented Oct 5, 2023

https://github.com/Mergifyio backport humble iron

@mergify
Copy link

mergify bot commented Oct 5, 2023 •
edited
Loading

backport humble iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 5, 2023
@ahcorde @mergify
Fixed parameter names (#28)
0d80ff2 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 45c42b0)
@mergify mergify bot mentioned this pull request Oct 5, 2023
Merged
mergify bot pushed a commit that referenced this pull request Oct 5, 2023
@ahcorde @mergify
Fixed parameter names (#28)
98b473d 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 45c42b0)
@mergify mergify bot mentioned this pull request Oct 5, 2023
Merged
ahcorde added a commit that referenced this pull request Oct 5, 2023
@mergify @ahcorde
Fixed parameter names (#28) (#29)
2d8b2de 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 45c42b0)

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Oct 5, 2023
@mergify @ahcorde
Fixed parameter names (#28) (#30)
fbf7d32 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 45c42b0)

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-maidbot john-maidbot john-maidbot approved these changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ahcorde @john-maidbot