Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CMake version to avoid CMP0048 warning #129

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 2, 2020

This bumps the minimum CMake version to 3.0.2, which is the minimum supported by ROS Kinetic and new enough to default to the NEW behavior of CMP0048. This avoids a CMake warning when building and testing this package in Debian Buster and Ubuntu Focal.

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
Copy link
Contributor

@v4hn v4hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've lived with this warning for a long time but did not know it was that easy to take care of 👍
Though apparently cmake stopped uttering the warning at some point and I don't see it anymore on cmake 3.17 .

@v4hn v4hn merged commit 127f79e into moveit:melodic-devel Apr 2, 2020
v4hn added a commit to TAMS-Group/bio_ik that referenced this pull request Apr 2, 2020
v4hn added a commit to TAMS-Group/move_group_online_collision_predictor that referenced this pull request Apr 2, 2020
v4hn added a commit to v4hn/moveit_msgs that referenced this pull request Apr 2, 2020
v4hn added a commit to v4hn/moveit_sim_controller that referenced this pull request Apr 2, 2020
@v4hn
Copy link
Contributor

v4hn commented Apr 2, 2020

followup: I can still reproduce the warning with 3.17 under some circumstances, but it does not appear for every package for me. Either way, bumping the minimal version to 3.0.2 does not harm with indigo out of support.

v4hn added a commit to v4hn/random_numbers that referenced this pull request Apr 2, 2020
v4hn added a commit to v4hn/moveit_visual_tools that referenced this pull request Apr 2, 2020
v4hn added a commit to v4hn/panda_moveit_config that referenced this pull request Apr 2, 2020
v4hn added a commit to v4hn/rosparam_shortcuts that referenced this pull request Apr 2, 2020
v4hn added a commit to v4hn/rqt_joint_trajectory_plot that referenced this pull request Apr 2, 2020
v4hn added a commit to v4hn/rviz_visual_tools that referenced this pull request Apr 2, 2020
v4hn added a commit to v4hn/srdfdom that referenced this pull request Apr 2, 2020
v4hn added a commit to v4hn/stomp_ros that referenced this pull request Apr 2, 2020
v4hn added a commit to v4hn/warehouse_ros that referenced this pull request Apr 2, 2020
v4hn added a commit to v4hn/moveit_sim_controller that referenced this pull request Apr 2, 2020
v4hn added a commit to v4hn/moveit_sim_controller that referenced this pull request Apr 2, 2020
gavanderhoorn pushed a commit to ros-industrial/stomp_ros that referenced this pull request Apr 2, 2020
JafarAbdi pushed a commit to PickNikRobotics/rviz_visual_tools that referenced this pull request Apr 2, 2020
JafarAbdi pushed a commit to PickNikRobotics/rosparam_shortcuts that referenced this pull request Apr 2, 2020
v4hn added a commit to moveit/moveit_msgs that referenced this pull request Apr 6, 2020
rhaschke pushed a commit to ubi-agni/moveit_msgs that referenced this pull request May 11, 2020
v4hn added a commit to TAMS-Group/bio_ik that referenced this pull request Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants