-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump CMake version to avoid CMP0048 warning #129
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've lived with this warning for a long time but did not know it was that easy to take care of 👍
Though apparently cmake stopped uttering the warning at some point and I don't see it anymore on cmake 3.17 .
Stop CMP0048 warning. moveit/geometric_shapes#129
followup: I can still reproduce the warning with 3.17 under some circumstances, but it does not appear for every package for me. Either way, bumping the minimal version to 3.0.2 does not harm with indigo out of support. |
Get rid of CMP0048 warning. moveit/geometric_shapes#129
get rid of CMP0048 warning moveit/geometric_shapes#129
Get rid of CMP0048 warning. moveit/geometric_shapes#129
get rid of CMP0048 warning. moveit/geometric_shapes#129
get rid of CMP0048 moveit/geometric_shapes#129
Get rid of CMP0048 warning. moveit/geometric_shapes#129
get rid of CMP0048 warning. moveit/geometric_shapes#129
Get rid of CMP0048 warning moveit/geometric_shapes#129
Get rid of CMP0048 warning. moveit/geometric_shapes#129
Stop CMP0048 warning. moveit/geometric_shapes#129
Stop CMP0048 warning. moveit/geometric_shapes#129
Get rid of CMP0048 warning moveit/geometric_shapes#129
Get rid of CMP0048 warning. moveit/geometric_shapes#129
get rid of CMP0048 warning. moveit/geometric_shapes#129
This bumps the minimum CMake version to 3.0.2, which is the minimum supported by ROS Kinetic and new enough to default to the NEW behavior of CMP0048. This avoids a CMake warning when building and testing this package in Debian Buster and Ubuntu Focal.
Signed-off-by: ahcorde ahcorde@gmail.com