pure virtual planning_request_adapter::initialize()
#1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We dismissed this approach in #1530, because this will leave existing plugins in a broken stage. |
Well, it is a breaking API change, yes. But I believe we agreed to allow for them in As I said, personally I'm open to have an empty default implementation too. |
rhaschke
approved these changes
Aug 14, 2019
gleichdick
pushed a commit
to gleichdick/industrial_core
that referenced
this pull request
Nov 13, 2019
PlanningRequestAdapter::initialize() is now pure virtual so we have to provide an empty implementation on each subclass. See also moveit/moveit#1621
gleichdick
pushed a commit
to gleichdick/industrial_core
that referenced
this pull request
Nov 13, 2019
PlanningRequestAdapter::initialize() is now pure virtual so we have to provide an empty implementation on each subclass. See also moveit/moveit#1621
gleichdick
pushed a commit
to gleichdick/industrial_core
that referenced
this pull request
Nov 15, 2019
PlanningRequestAdapter::initialize() is a pure virtual function on current moveit master so we have to provide an empty implementation on each subclass. See also moveit/moveit#1621
henningkayser
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
Nov 21, 2019
Implement initialize as pure virtual function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method was introduced in #1530, together with a TODO to make it pure virtual "in O-turtle".
A Windows-compatibility pr noticed that the current functionality is not available in Windows, as it uses
cxxabi.h.I would propose to either go for the pure virtual method directly or just implement an empty default implementation (apparently this was dismissed in #1530).