Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan_execution: refine logging for invalid paths #1705

Merged

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Oct 30, 2019

This differentiates between checks caused by scene updates
and checks caused by changing trajectory components.

Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I approve and see the upside to having this refinement. See comment below, less code means less confusion ;)

moveit_ros/planning/plan_execution/src/plan_execution.cpp Outdated Show resolved Hide resolved
This differentiates between checks caused by scene updates
and checks caused by changing trajectory components.
@v4hn v4hn force-pushed the pr-master-more-specific-invalid-plan-parts branch from 0d549f0 to 882f6dc Compare November 4, 2019 13:23
@rhaschke rhaschke merged commit ea399e6 into moveit:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants