jog_arm: add a C++ API #1763
Merged
jog_arm: add a C++ API #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndyZe Thanks for preparing this! I'll give this a test but so far the implementation seems very reasonable to me. |
|
@AndyZe thanks for fixing this up, CI fails unrelated to this PR |
henningkayser
approved these changes
Dec 4, 2019
moveit_experimental/moveit_jog_arm/include/moveit_jog_arm/jog_interface_base.h
Outdated
Show resolved
Hide resolved
|
Looks great! lgtm |
Start a new folder, src/cpp_interface_example
Codecov Report
@@ Coverage Diff @@
## master #1763 +/- ##
==========================================
- Coverage 48.3% 48.26% -0.04%
==========================================
Files 294 297 +3
Lines 23232 23261 +29
==========================================
+ Hits 11223 11228 +5
- Misses 12009 12033 +24
Continue to review full report at Codecov.
|
mamoll
requested changes
Dec 5, 2019
moveit_experimental/moveit_jog_arm/include/moveit_jog_arm/jog_interface_base.h
Outdated
Show resolved
Hide resolved
mamoll
approved these changes
Dec 11, 2019
tylerjw
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
May 12, 2020
* Example to launch C++ interface in a new thread * A better multithread example Start a new folder, src/cpp_interface_example * Update license formatting in new files only * JogROSInterface inherits from a base class * Base interface class is don * The new API half-works :P * Sharing data between threads workks * It works! The arm moves * Add C++ interface launch file * Implement joint commands * Debug the demo transition from cartesian to joint commands * Add an example of retrieving the current joint state * Clang format * Satisfy linter re. function names * Ensure the library is available to other packages * Update license formatting again * Clang format * Switch pthread to std::thread, change C++14 compiler options * Clang format
tylerjw
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
May 12, 2020
* Example to launch C++ interface in a new thread * A better multithread example Start a new folder, src/cpp_interface_example * Update license formatting in new files only * JogROSInterface inherits from a base class * Base interface class is don * The new API half-works :P * Sharing data between threads workks * It works! The arm moves * Add C++ interface launch file * Implement joint commands * Debug the demo transition from cartesian to joint commands * Add an example of retrieving the current joint state * Clang format * Satisfy linter re. function names * Ensure the library is available to other packages * Update license formatting again * Clang format * Switch pthread to std::thread, change C++14 compiler options * Clang format
tylerjw
pushed a commit
to PickNikRobotics/moveit
that referenced
this pull request
May 20, 2020
* Example to launch C++ interface in a new thread * A better multithread example Start a new folder, src/cpp_interface_example * Update license formatting in new files only * JogROSInterface inherits from a base class * Base interface class is don * The new API half-works :P * Sharing data between threads workks * It works! The arm moves * Add C++ interface launch file * Implement joint commands * Debug the demo transition from cartesian to joint commands * Add an example of retrieving the current joint state * Clang format * Satisfy linter re. function names * Ensure the library is available to other packages * Update license formatting again * Clang format * Switch pthread to std::thread, change C++14 compiler options * Clang format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a C++ API. There's an example in src/cpp_interface_example