documentation mismatch in kinematic_constraint.h #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a mismatch between the documentation and the implementation. Implementation uses XYZ Euler angles, documentation says ZXZ.
|
Thanks for helping in improving MoveIt and open source robotics! |
Codecov Report
@@ Coverage Diff @@
## master #1793 +/- ##
=======================================
Coverage 47.53% 47.53%
=======================================
Files 290 290
Lines 22932 22932
=======================================
Hits 10901 10901
Misses 12031 12031
Continue to review full report at Codecov.
|
|
Congrats on getting your first MoveIt pull request merged and improving open source robotics! |
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Mar 30, 2020
Implementation uses XYZ Euler angles (RPY), but documentation said ZXZ.
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Mar 31, 2020
Implementation uses XYZ Euler angles (RPY), but documentation said ZXZ.
v4hn
pushed a commit
to v4hn/moveit
that referenced
this pull request
Mar 31, 2020
Implementation uses XYZ Euler angles (RPY), but documentation said ZXZ.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a mismatch between the documentation and the implementation.
Implementation uses XYZ Euler angles, documentation says ZXZ.
The implementation can be seen in kinematic_constraint.cpp and in default_constraint_samplers.cpp.
I don't think the checklist below is relevant for such a small change (only a single line).
Is such a small change even worth a pull request?
Checklist