Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pos_vel_controllers and pos_vel_acc_controllers #1806

Merged

Conversation

samagalhaes
Copy link
Contributor

@samagalhaes samagalhaes commented Dec 9, 2019

Added support for ros_control controllers:

  • pos_vel_controllers/JointTrajectoryController
  • pos_vel_acc_controllers/JointTrajectoryController

Description

Adds the pos_vel_controllers/JointTrajectoryController and the pos_vel_acc_controllers/JointTrajectoryController to the moveit_ros_control_plugin_interface.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Added the support for the new controllores derived from
JointTrajectoryControllers.
Just adds the acknowledge for this controller in the moveit ros control
plugin interface
@welcome
Copy link

welcome bot commented Dec 9, 2019

Thanks for helping in improving MoveIt and open source robotics!

Copy link
Member

@davetcoleman davetcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ipa-mdl you created the first version of the plugins, does this look ok to you?

Copy link
Contributor

@mathias-luedtke mathias-luedtke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work 👍

@davetcoleman davetcoleman merged commit 9a01d69 into moveit:melodic-devel Jan 22, 2020
@welcome
Copy link

welcome bot commented Jan 22, 2020

Congrats on getting your first MoveIt pull request merged and improving open source robotics!

davetcoleman pushed a commit that referenced this pull request Jan 22, 2020
* Add support for pos_vel_controllers and pos_vel_acc_controllers

Added the support for the new controllores derived from
JointTrajectoryControllers.
Just adds the acknowledge for this controller in the moveit ros control
plugin interface

* Clang-format correct
@davetcoleman
Copy link
Member

cherry picked to master

sjahr pushed a commit to sjahr/moveit that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants