[AIST-QA] Initialized scene_manager_ member varianle in OcTreeRender constructor #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correct the indication by the static analysis tool. - Added 'scene_manager_' initializer to constructor.
rhaschke
approved these changes
Jan 1, 2020
rhaschke
pushed a commit
to ubi-agni/moveit
that referenced
this pull request
Jan 1, 2020
Require a valid parent_node to be passed. Modified cherry-pick of moveit#1817.
rhaschke
added a commit
that referenced
this pull request
Jan 1, 2020
Require a valid parent_node to be passed. Modified cherry-pick of #1817.
max-krichenbauer
deleted the
feature/analysis_tool/melodic/Uninitialize_variable_Constructor/moveit_ros
branch
sjahr
pushed a commit
to sjahr/moveit
that referenced
this pull request
Jun 21, 2024
This is a proper dependency, and not only a test dependency. It is still needed when building moveit_core with -DBUILD_TESTING=OFF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The member variable
scene_manager_is not initialized in the constructor ofOcTreeRender. Since a parameter calledscene_managerexists in the constructor arguments, it appears to have been forgotten to initializesacene_manager_.This fix adds initialization of
scene_manager_to theOcTreeRenderconstructor.This contribution is made by AIST ( https://www.aist.go.jp ) based on static code analysis with klocwork (Perforce Software).
Checklist