[AIST-QA] Fix potential use of uninitialized variable in moveit_ros. #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tylerjw what happened to the CodeCov automatic reports? Is that tool broken right now? |
davetcoleman
pushed a commit
that referenced
this pull request
Dec 31, 2019
…t_from_text.cpp. (#1818)
|
Cherry picked to master |
|
@davetcoleman Looks like the aren't being run if you look at the travis run for this one. |
|
We have codecov enabled for the master branch only. |
max-krichenbauer
deleted the
feature/analysis_tool/melodic/Uninitialize_variable/moveit_ros
branch
sjahr
added a commit
to sjahr/moveit
that referenced
this pull request
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The local variable
valueis not initialized and stored instd::map <std::string, double> v[joint]regardless of whethermakerequals"="or not. For that reason, it may cause undefined behavior ifmarkeris"="andvalueis not set via input stream.This fix extends the scope of the conditional branch of
marker:valueis storedv[joint]only whenmarkerequals"=".This contribution is made by AIST ( https://www.aist.go.jp ) based on static code analysis with klocwork (Perforce Software).
Checklist